search

fluentsharp / FluentSharp

Fluent API for the .NET Framework (used by the O2 Platform)
63 stars 18 forks source link

Added description and unit tests to IO_ExtensionMethods_Folders.cs ( https://github.com/o2platform/FluentSharp/issues/10) #42

Closed alexandrustanimir closed 9 years ago

alexandrustanimir commented 9 years ago

I tried to add also extra checks for some functions, hope it is ok . There is also a fix for a problem in String_ExtensionMethods.cs which I missed in the previous pull request.

alexandrustanimir commented 9 years ago

And the screenshot after unit tests execution. image

DinisCruz commented 9 years ago

Thanks again for sending such great commits, I've gone though all changes and added some comments.

Btw, this PR at the moment cannot be automatically merged which means that there is either a conflict or you need to do a pull request to update your fork:

image

DinisCruz commented 9 years ago

here is the prob, you need to pull from FluentSharp/master image

alexandrustanimir commented 9 years ago

Yes , that`s pretty cool :). However is still a mystery why the previous build failed because of an unit test. Maybe the Linux machine is not such a good host for .Net :).

DinisCruz commented 9 years ago

Great stuff, added a couple more comments for you in there

Thanks for all the great contributions

DinisCruz commented 9 years ago

Great stuff, I'll do the final merge this weekend

DinisCruz commented 9 years ago

HI @alexandrustanimir I merged the code and it's all now on the main repo. THANKS a lot for the PR :) :) :) :100:

I made a couple changes and it would be great if you could review them:

Fell free to ask any questions if you are not sure why I made a particular change.

I hope that some of the changes will help you to understand better the logic and philosophy behind FluentSharp

See also comments on https://github.com/o2platform/FluentSharp/issues/45