search

fluffle / sp0rkle

sp0rkle is dead, long live sp0rkle
irc://irc.pl0rt.org/#ed
8 stars 4 forks source link

Time parsing problems 24 hour clock #10

Closed gundalow closed 11 years ago

gundalow commented 11 years ago

[10:06] < foo> sp0rklf: remind me expenses at 1130am [10:06] < sp0rklf> foo: okay, i'll remind you expenses at 02:00:00, Thursday 14 March 2013

in the short term maybe instruct the user to do "11:30" for any remind at followed by 4 digits + optional am/pm?

fluffle commented 11 years ago

This one isn't easy, due to the ambiguities I mentioned previously w.r.t. 2013 and, well, 2013. The former being the year 2013, and the latter being 13 minutes past 8 in the evening. Or vice versa, it's hard to tell...

gundalow commented 11 years ago

maybe just print usage if called with XXXX[am|pm]

On 14 March 2013 09:22, Alex Bee notifications@github.com wrote:

This one isn't easy, due to the ambiguities I mentioned previously w.r.t. 2013 and, well, 2013. The former being the year 2013, and the latter being 13 minutes past 8 in the evening. Or vice versa, it's hard to tell...

— Reply to this email directly or view it on GitHubhttps://github.com/fluffle/sp0rkle/issues/10#issuecomment-14892915 .

fluffle commented 11 years ago

Hah, I think I know what that's actually doing: 1130am is parsed as 1130 hours into the morning, like 10am is 10 hours into the morning. 1130 % 24 == 2, hence 2am. I can therefore hack the parser so that 1130{a,p}m works correctly. 24h four digits are still ambiguous, but I think it's more likely that HHMM rather than YYYY will be used on IRC.