search

fluffle / sp0rkle

sp0rkle is dead, long live sp0rkle
irc://irc.pl0rt.org/#ed
8 stars 4 forks source link

Basic markov support #2

Closed pzsz closed 11 years ago

pzsz commented 11 years ago

Contains lots of errors, could use some more documentation and I fell lazy :). Will provide moar when I get bored again :).

May put some more strain on the db, it does multiple updates per every sentence it hears.

fluffle commented 11 years ago

Awesome. Will try to find adequate time for review this week :-)

fluffle commented 11 years ago

Oh man, github's code review is a bit special. Each comment being a separate discussion thread is a little unwieldy.

I've one overarching thing to add to this: we need some kind of "don't markov me bro" killswitch, since some people may not want to have every sentence they utter added to the bot's database, especially when it's explicitly tied to their nick. You might want to ask people on the channel how they feel...

Perhaps instead it ought to be an opt-in thing where we teach it sentences for specific tags. I can see that being entertaining and far less potentially incriminating ;-)

fluffle commented 11 years ago

Hope you don't mind that I ripped it apart a bit, thanks for the code :-)

I'll be live in sp0rkle when I get back from the states.