search

fluffy-mods / ColonyManager

Colony manager for RimWorld
Other
71 stars 39 forks source link

Add Feature to Unassign Training #146

Closed maarxx closed 4 years ago

maarxx commented 4 years ago

I had a case where I specifically wanted to mark new animals as not to maintain Tameness.

Currently, the mod will not unassign traininig, it will only assign new training.

~This PR adds a Mod Setting to unassign training if desired.~

We also move DoTrainingJobs in front of DoAreaRestrictions since the former can influence the latter.

FluffierThanThou commented 4 years ago

interesting idea, and I can see the use of it. Good call on moving doTraining before doAreaRestrictions, that should have been the order anyway.

I think I'd prefer adding a de-assign toggle to the actual job though, that both allows more granularity, and makes it easier for players to link the setting to what they see happening.

maarxx commented 4 years ago

I think I'd prefer adding a de-assign toggle to the actual job though, that both allows more granularity, and makes it easier for players to link the setting to what they see happening. ~ @FluffierThanThou

Done.

PR updated, please take a look.

Thanks for the mod.

FluffierThanThou commented 4 years ago

thanks for taking my notes into account. I apologize for taking so long to review them. Will look at them now.