search

fluffy-mods / ColonyManager

Colony manager for RimWorld
Other
71 stars 39 forks source link

foraging jobs ignore threshold #150

Closed CodeOptimist closed 4 years ago

CodeOptimist commented 4 years ago

Describe the bug
selected foraging thing isn't added to count filter (gear menu)

Expected behavior
after selecting it on right side, should show up in filter, like with other tabs

Steps to reproduce

  1. forage tab
  2. click <New job>
  3. select any plant / bush / healroot
  4. check count filter gear menu
  5. observe it empty

Other mods

I wouldn't do you dirty like that. Just HugsLib.

Output log

Save game

Screenshots

Environment
Win10 64

Game 64 Steam 1.0

dandiez commented 4 years ago

@CodeOptimist I could not reproduce the bug... Did you start a new game or was this issue on an existing save? Do you effectively see an empty dialog (the one with the clear all / allow all buttons below?) Untitled

CodeOptimist commented 4 years ago

@dandiez New games AND existing saves. With only HugsLib and Colony Manager. Yes, just like that.

If you skip step 2 the counted filter has some defaults, but those also don't update as "Allowed plants" is tweaked.

The Mining tab keeps "Minerals" and the counted filter completely in sync, when I check/uncheck one it updates in the other. I expected Foraging to work like this as well.

Although actually it looks like Foraging allows you to count anything, whereas Mining restricts the count filter to actual minerals.

That's actually cool and I wouldn't mind if all the tabs had independent "do this" and "count this", but it seems selecting a plant to forage should still probably include it to be counted automatically.

FluffierThanThou commented 4 years ago

Actually, this was working as intended, but I've now added the sync functionality to the foraging tab as well.