search

fluffy-mods / ModManager

managing mods should be easy
Other
88 stars 32 forks source link

Autosort pulls in inactive, but subscribed mods into active list. #146

Open shakeyourbunny opened 3 years ago

shakeyourbunny commented 3 years ago

Describe the bug
Autosort does pull in inactive, but subscribed mods into the active modlist.

This is REALLY REALLY annoying if you have doublechecked your mod list, ensure that no mod that I currently dislike or not want to use in a playthrough suddenly pops up after having played for some time, especially Dubs Bad Hygiene or Hospitality which really like to sneak in.

Expected behavior
Autosort only sorts active mods and does not pull in inactive, subscribed mods.

Steps to reproduce

  1. subscribe to a bunch of Vanilla Expanded mods, also Vanilla Faction Vikings Storyteller, also some which the storyteller mod has no dependency on.
  2. press the magic wand for autosort
  3. see all Vanilla Expanded mods pulled in

Other mods
Any mods where they are subscribed, but not active and appear in LoadAfter and/or LoadBefore

Environment

Game

FluffierThanThou commented 3 years ago

it might be adding mods that are referenced in load orders for other mods, even if (either mod a or b, stories differ) is not enabled.

FluffierThanThou commented 3 years ago

reported by:
Traschy

description:

Whenever I click the autosort button to get rid of conflicts, the mod manager adds other, unrelated mods to my modlist. I only realise when I check the mod mismatch screen or when I start a game and find unwanted mods in my game. The mods this consistently happens with are SOS2, A Rimworld of Magic, and Vanilla Cooking Expanded.Any ideas on how to fix it?

Dev5H0 commented 3 years ago

Since this still has the "Trying to replicate" tag: Subscribe to "Combat Extended" and "RPG Style Inventory Revamped"; add "RPG Style Inventory Revamped" to the load order, and press the autosort button; "Combat Extended" will automatically be added to the load order, reason being that "RPG Style Inventory Revamped"'s "loadAfter" includes "Combat Extended".

panicmod-e commented 2 years ago

I ran into this issue as well and was wondering where it came from. I am actively using "RPG Style Inventory Revamped" and am subscribed to "Combat Extended", but don't have it enabled. When I auto-sort it enables "Combat Extended" automatically.

The same happens with "Expanded Prosthetics and Organs" and "Expanded Prosthetics and Organs - Forked", I have the forked version enabled, but it seems because the forked version has the original version listed as not compatible, when auto-sorting the original version gets enabled again regardless.