fluffy-mods / ResearchTree

Graphical research tree and queue system for RimWorld
Other
23 stars 24 forks source link

Incompatible with Research Pal 1.1 #37

Closed Gwilt closed 4 years ago

Gwilt commented 4 years ago

Describe the bug
When both Research Tree and Research Pal are installed there are graphical issues when in the colony screen - tooltips remain on screen and the main menu is unavailable.

See - https://drive.google.com/file/d/1XxJd4eLRE-NFMbLqXzjF7cqazLZ6T9tD/view?usp=sharing

Expected behavior
I wasn't aware that both mods essentially did the same thing

Steps to reproduce
Install Research Tree (with dependencies) and Research Pal

Other mods
As above.

Output log

Save game

Screenshots

https://drive.google.com/file/d/1XxJd4eLRE-NFMbLqXzjF7cqazLZ6T9tD/view?usp=sharing

Environment

Game

Comment It took me about 30 - 45 minutes to troubleshoot the issue. At the time I didn't relaise both mods essentially did the same thing and thus only one of the other would be required. Could you please add a comment / disclaimer to Research Tree indicating that if you have both mods installed at the same time that the user might experience issues. Rimworld

notfood commented 4 years ago

I should be able to add an "incompatible with" in the About.xml

FluffierThanThou commented 4 years ago

same on this side. Granted, this should have been fairly obvious, but making it explicit can't hurt.

On Mon, Mar 9, 2020 at 5:21 PM Meru notifications@github.com wrote:

I should be able to add an "incompatible with" in the About.xml

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/fluffy-mods/ResearchTree/issues/37?email_source=notifications&email_token=AENLQMRW3RBEX6BYL5PMWM3RGUJPNA5CNFSM4LEHJ3E2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEOH5UXA#issuecomment-596630108, or unsubscribe https://github.com/notifications/unsubscribe-auth/AENLQMWUAY67HGL4JIILTZDRGUJPNANCNFSM4LEHJ3EQ .

ELLIOTTCABLE commented 4 years ago

Hey there; just adding a log, since one wasn't included in the O.P.: launched with only Mod Manager, HugsLib, and ResearchPal/ResearchTree.

https://gist.github.com/ELLIOTTCABLE/51e85aa7aa38b53b8f1eb0fff926f89b

I would like to 👍 for a fix, though, if at all possible - with enough mods installed, the two graph-layout algorithms produce substantially different results, and it'd be nice to be able to run the game with both of them, allowing someone to decide which layout they prefer for a given .

Obviously, a non-pressing issue; but I thought I'd throw this in there! <3

FluffierThanThou commented 4 years ago

I'm afraid this is just not something that has even a remote priority. Both mods implement a research queue system with pretty much the same code, that simply cannot exist together nicely, and it's not really worth the effort to try and make them.

You're just gonna have to try the two algorithms one by one, sorry ;)