search

fluffy-mods / WorkTab

A better Work Tab for RimWorld
Other
51 stars 33 forks source link

Possible Incompatibility with Prepare Carefully #100

Closed Amnesiac9 closed 5 years ago

Amnesiac9 commented 6 years ago

Upon starting a game, I added Map Reroll to my mod list, and started getting a huge amount of errors as shown in this screenshot: https://i.imgur.com/duiRnEC.png

The errors say something about work tab, so I wanted to report it here on the off chance you can understand what's happening and maybe find out why.

Only happens when I load the game.

Amnesiac9 commented 6 years ago

Modlist that I was using before adding Map Reroll and starting a new game:

  • Core
  • HugsLib
  • EdB Prepare Carefully
  • Allow Tool
  • Animal Tab
  • Medical Tab
  • Relations Tab
  • Work Tab
  • Blueprints
  • Research Tree
  • Colony Manager
  • Dubs Mint Menus
  • Fluffy Breakdowns
  • ExtendedInspectData [B19]
  • Hand Me That Brick Lite
  • Pick Up And Haul
  • Dismiss Trader
  • P-Music
  • VGP Vegetable Garden
  • VGP_CoffeeTeaDrugs
  • VGP Garden Medicine
  • Heat Map
  • RT Fuse
  • Wandering Caravans [v2.3.5]
  • [KV] Show Hair With Hats or Hide All Hats - B19
  • ED-Embrasures
  • [B19] Wild Animal Sex V3.2
  • VGP Garden Tools
  • Room Food
  • [KV] RimFridge - B19
  • PowerSwitch
  • Animals Logic
  • Stack XXL
    •
    Amnesiac9 commented 6 years ago

    Ok, I was wrong, the incompatibility is with Prepare Carefully!

    https://github.com/edbmods/EdBPrepareCarefully/issues/241

    Amnesiac9 commented 6 years ago

    Here's a copy and paste of my issue report on Prepare Carefully.

    Hello,

    So I've been getting errors with my mods and did a TON of testing, and I've found an incompatibility with Fluffy's Work Tab and Prepare Carefully.

    After starting a game with only 3 mods, then upon SAVING and Loading the game thereafter, I receive this error log: https://git.io/fA1o1

    Pic of the error: https://i.imgur.com/sKzspwF.png

    The Mod List:

    Some info from testing:

    The Errors DO happen when I:

    Start a new game, choose prepare carefully with 3 colonists, change no settings at all, save game, quit to main menu, load game. Each time I load, the errors happen.

    Hopefully this helps!!

    FluffierThanThou commented 5 years ago

    Hey,

    Thanks for the extensive report, and all the work you've put into it. I'm sorry it took me so long to reply, life got in the way.

    The warnings and errors you're seeing are - as far as I understand it - a result of Prepare Carefully generating pawns, but never disposing of them correctly. When the pawns are generated, their work settings are generated too, which triggers Work Tab to create and store their priorities. When it comes to actually saving these priorities, Work Tab checks to see if the pawns they belong to have been destroyed, or otherwise disposed of. Since Prepare Carefully doesn't mark them as destroyed, Work Tab saves a reference to them, but these 'ghost' pawns are themselves never actually saved by the game. When the game tries to load the priorities, it fails to find the referenced pawns, and gives a bunch of errors.

    The good news is that these errors are harmless, and they will only occur once. The bad news is that there's not much that I can do, there's not really any good way for me to check if a pawn exists other than trusting what that pawn tells me.