fluffymuffin27 / take10

P2P Tabletop RPG Engine
GNU Affero General Public License v3.0
3 stars 2 forks source link

Test for Ability Score Generators returning values above 18 #2

Closed fluffymuffin27 closed 7 years ago

fluffymuffin27 commented 7 years ago

Currently we test for scores less than 0, but not for scores higher than 18, as noted on the wiki planning document.

IMPrager commented 7 years ago

Keep in mind that Point Buy changes things up a bit:

Users still can't increase scores above 18 as far as I know.

hamiltonium commented 7 years ago

I've altered the test to raise an error when dexterity is greater than 18. For some reason, it looks like the coverage dropped a bit when I added that line of code.

fluffymuffin27 commented 7 years ago

Coverage may have dropped because it might still consider whether the test files themselves are 'covered'. Not unusual.

Fixed by #4