search

fluffysquirrels / mqtt-async-client-rs

An MQTT client written in Rust
MIT License
40 stars 16 forks source link

ConnectionMode is not exposed #26

Closed marcelbuesing closed 3 years ago

marcelbuesing commented 3 years ago

The ConnectionMode enum is not exposed and probably should be or set_connection_mode should be private.

https://docs.rs/mqtt-async-client/0.3.1/mqtt_async_client/client/struct.ClientBuilder.html#method.set_connection_mode

fluffysquirrels commented 3 years ago

Hmmm, my inclination is to make set_connection_mode private as we already let the user configure this through their choice of URL and allowing them to configure through both might be confusing.

marcelbuesing commented 3 years ago

Yes I agree. I think even better is to remove the function for now. It's apparently not being used anywhere internally in the code, other functions directly set the field. I have updated the PR, feel free to also just change it like that and close the PR.

fluffysquirrels commented 3 years ago

Looks good, thanks for this.