fluid-cloudnative / fluid

Fluid, elastic data abstraction and acceleration for BigData/AI applications in cloud. (Project under CNCF)
https://fluid-cloudnative.github.io/
Apache License 2.0
1.64k stars 955 forks source link

[FEATURES]Support Running in Apple M1 #1012

Open swartz-k opened 3 years ago

swartz-k commented 3 years ago

What feature you'd like to add: ENV: Apple M1 While running below code,

 make test

will meet errors as below

....
# github.com/agiledragon/gomonkey
../../../../pkg/mod/github.com/agiledragon/gomonkey@v2.0.2+incompatible/patch.go:163:10: undefined: buildJmpDirective
make: *** [vet] Error 1

Ref gomonkey issue 38

Some changes needed

--- a/go.mod
+++ b/go.mod
@@ -1,9 +1,9 @@

 require (
-       github.com/agiledragon/gomonkey v2.0.2+incompatible
+       github.com/agiledragon/gomonkey/v2 v2.2.0
--- a/pkg/ddc/alluxio/cache_test.go
+++ b/pkg/ddc/alluxio/cache_test.go
@@ -4,7 +4,7 @@ import (
        "reflect"
        "testing"

-       . "github.com/agiledragon/gomonkey"
+       . "github.com/agiledragon/gomonkey/v2"

Why is this feature needed: I am not sure if this needed. :-)

cheyang commented 3 years ago

Thanks for opening it. @swartz-k , if you'd like open an PR on fixing it, we will be very appreciated.

swartz-k commented 3 years ago

Thanks for opening it. @swartz-k , if you'd like open an PR on fixing it, we will be very appreciated.

Sure, I will do that. And also should we upgrade go version and newer k8s lib maybe v0.18.x -> v0.2x.x