search

fluid-cloudnative / fluid

Fluid, elastic data abstraction and acceleration for BigData/AI applications in cloud. (Project under CNCF)
https://fluid-cloudnative.github.io/
Apache License 2.0
1.58k stars 949 forks source link

refactor: rename `CreateUpdatePodForSchedulingHandler` to `FluidMutatingHandler` #4168

Closed TrafalgarZZZ closed 2 weeks ago

TrafalgarZZZ commented 2 weeks ago

Ⅰ. Describe what this PR does

CreateUpdatePodForSchedulingHandler is Fluid webhook's mutating handler who injects specs like node affinity, mount propagation and FUSE sidecars into a Pod. The name CreateUpdatePodForSchedulingHandler is confusing and it needs to be fixed to better indicate its role in Fluid.

Code Changes in this PR:

Ⅱ. Does this pull request fix one issue?

NONE

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

fluid-e2e-bot[bot] commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheyang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/fluid-cloudnative/fluid/blob/master/OWNERS)~~ [cheyang] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment