refactor: avoid passing namespace to mutation functions - Githubissues

fluid-cloudnative / fluid

Fluid, elastic data abstraction and acceleration for BigData/AI applications in cloud. (Project under CNCF)

https://fluid-cloudnative.github.io/

Apache License 2.0

1.58k stars 949 forks source link

refactor: avoid passing namespace to mutation functions #4171

Closed TrafalgarZZZ closed 2 weeks ago

TrafalgarZZZ commented 2 weeks ago

Ⅰ. Describe what this PR does

Code changes in this PR:

Override pod.Namespace with req.Namespace. This is only effective before K8s 1.24, see discussion and the bugfix in https://github.com/kubernetes/kubernetes/issues/113952#issuecomment-1317042694
By overriding pod.Namespace, we avoid passing namespace into deeper mutation functions and make code clearer.

Ⅱ. Does this pull request fix one issue?

None

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

fluid-e2e-bot[bot] commented 2 weeks ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from cheyang by writing /assign @cheyang in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/fluid-cloudnative/fluid/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment