fluid-cloudnative / fluid

Fluid, elastic data abstraction and acceleration for BigData/AI applications in cloud. (Project under CNCF)
https://fluid-cloudnative.github.io/
Apache License 2.0
1.58k stars 949 forks source link

dataset support pvc storageSize #4178

Closed wangshulei098 closed 1 week ago

wangshulei098 commented 2 weeks ago

Ⅰ. Describe what this PR does

The generated PVC and PV have a fixed size of 100 Pi and cannot be changed. In a namespace with a Resourcequota set for storage, it is not possible to create such large PV and PVC. Therefore, the size needs to be configurable.

Ⅱ. Does this pull request fix one issue?

fixes #4177

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

Ⅳ. Describe how to verify it

“pvc.fluid.io/resources.requests.storage” as the annotation key on Dataset to specify the desired storage size for the generated PVC. If not set, or if the storage size format is incorrect, it will be set to the default value of 100Pi.

Ⅴ. Special notes for reviews

fluid-e2e-bot[bot] commented 2 weeks ago

Hi @wangshulei098. Thanks for your PR.

I'm waiting for a fluid-cloudnative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
cheyang commented 1 week ago

/test fluid-e2e

cheyang commented 1 week ago

@wangshulei098 Thanks for your contributions! @TrafalgarZZZ please also take a look. Thanks.

cheyang commented 1 week ago

@wangshulei098 Would you mind developing document for this? Thanks. It can be next PR.

fluid-e2e-bot[bot] commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheyang, TrafalgarZZZ

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/fluid-cloudnative/fluid/blob/master/OWNERS)~~ [TrafalgarZZZ,cheyang] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment