search

fluid-cloudnative / fluid

Fluid, elastic data abstraction and acceleration for BigData/AI applications in cloud. (Project under CNCF)
https://fluid-cloudnative.github.io/
Apache License 2.0
1.58k stars 949 forks source link

minorfix: do not skip mutation for fluid pods #4184

Closed TrafalgarZZZ closed 1 week ago

TrafalgarZZZ commented 1 week ago

Ⅰ. Describe what this PR does

Fluid webhook skips mutation for runtime pods by checking if it has a label app: <runtimeType>. This is not what we want in some cases. For example, an AlluxioRuntime accelerating a PVC that backed by another Runtime. In such case, AlluxioRuntime's master and worker pods should mount the PVC so they should be mutated.

Ⅱ. Does this pull request fix one issue?

NONE

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

fluid-e2e-bot[bot] commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheyang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/fluid-cloudnative/fluid/blob/master/OWNERS)~~ [cheyang] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment