fluid-cloudnative / fluid

Fluid, elastic data abstraction and acceleration for BigData/AI applications in cloud. (Project under CNCF)
https://fluid-cloudnative.github.io/
Apache License 2.0
1.68k stars 960 forks source link

Fix code scanning alert - Prefer COPY over ADD #4378

Closed omerap12 closed 3 weeks ago

omerap12 commented 1 month ago

Ⅰ. Describe what this PR does

Fix code scanning alert - Replace ADD in Dockerfiles to COPY

Ⅱ. Does this pull request fix one issue?

fixes #4354

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

cheyang commented 3 weeks ago

@omerap12 Please don't change vendor/github.com/nxadm/tail/Dockerfile

omerap12 commented 3 weeks ago

@omerap12 Please don't change vendor/github.com/nxadm/tail/Dockerfile

Yeap, sorry :(

sonarcloud[bot] commented 3 weeks ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

fluid-e2e-bot[bot] commented 3 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheyang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/fluid-cloudnative/fluid/blob/master/OWNERS)~~ [cheyang] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment