What kind of change does this PR introduce? (check at least one)
[ ] Bugfix
[ ] Feature
[ ] Enhancement
[ ] Accessibility
[ ] Documentation update
[ ] Other (please describe)
If new features/enhancement are added or changed:
A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)
If Pull request is a Bugfix:
Add referenced in the PR's title (i.e. [...] (fixes #xxx[,#xxx]), where "xxx" is the issue number) (if any)
Explain how does this PR solves the issue.
It should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
Tradeoffs
What are the drawbacks of this PR? (if any)
Are there alternative Solutions? (if any)
Performance Tradeoffs (if any)
Usability Tradeoffs (if any)
Complexity Tradeoffs (if any)
Does this PR introduce a breaking change? (check one)
[ ] No
[ ] Yes (please describe)
Did you tested this PR?
[ ] No
[ ] Yes (please describe)
ARIA Accessibility has been taken into consideration?
Does it affect screen reader users or keyboard only users? Clickable items should be in the tab index, etc.
aliraza401
commented
4 years ago
Describe the Pull request
A clear and concise description of what the pull request does.
Checklist
Before submitting
yarn tryto test run code.What kind of change does this PR introduce? (check at least one)
If new features/enhancement are added or changed:
If Pull request is a Bugfix:
[...] (fixes #xxx[,#xxx]), where "xxx" is the issue number) (if any)Tradeoffs
Does this PR introduce a breaking change? (check one)
Did you tested this PR?
ARIA Accessibility has been taken into consideration?
Does it affect screen reader users or keyboard only users? Clickable items should be in the tab index, etc.