search

fluid-lab / gamepad-navigator

GSoC 2020 project
Other
6 stars 10 forks source link

Gamepad Navigator breaks embedded players on some sites. #184

Closed duhrer closed 2 months ago

duhrer commented 3 months ago

For example, Dollar Country does not work with the default options enabled.

duhrer commented 3 months ago

This is related to the "link external iframes" setting introduced in #169. The missing players are linked and open in a new window, but the content disappears and the size is all wrong.

duhrer commented 3 months ago

Looks like the wrapping breaks the styles because it mistakenly moves the iframe out of its containing "row" element. If I hard code the width to 100% in the dev console, the content is visible. Seems like we just need to ensure that the wrapper is contained within the same element that originally contained the iframe? Depending on the styles this may also break things, but it should break less often.

duhrer commented 3 months ago

That might have been a red herring, seems like their row element is an empty placeholder for tweaking the margins.

duhrer commented 2 months ago

I was able to fix this by removing the width and height styles from the wrapper, which leave it to the wrapped content to size itself.