search

fluid-project / fluid-lint-all

Consolidated linting logic free from any particular build technology
BSD 3-Clause "New" or "Revised" License
0 stars 5 forks source link

GH-16: Improve code coverage (resolves #16). #18

Closed the-t-in-rtf closed 3 years ago

the-t-in-rtf commented 3 years ago

See #16 for details.

the-t-in-rtf commented 3 years ago

Previously, coverage totals were:

90.45% Statements 398/440
79.41% Branches 81/102
88.06% Functions 59/67
90.45% Lines 398/440

With the changes in this pull:

97.73% Statements 430/440
90.2% Branches 92/102
97.01% Functions 65/67
97.73% Lines 430/440
the-t-in-rtf commented 3 years ago

I updated the NYC config file (.nycrc) to set coverage thresholds that will result in errors in CI if the coverage falls below 95% for everything but branches, which I set to 90%. The branch threshold is pretty tight, we may have to relax that or add comments to ignore hard-to-test branches.