search

fluid-project / fluid-lint-all

Consolidated linting logic free from any particular build technology
BSD 3-Clause "New" or "Revised" License
0 stars 5 forks source link

Newlines check returns errors for PDF and PPTX files #25

Closed greatislander closed 3 years ago

greatislander commented 3 years ago

Describe the bug

Some more files which are erroneously included in the lintspaces.newlines check: .docx and .pdf.

To reproduce

Steps to reproduce the behavior:

  1. Run the lintspaces.newlines check against a project which contains PDF or PPTX files (e.g. https://github.com/codelearncreate/c2lc-project-website/runs/1979991318?check_suite_focus=true)
  2. See the test failure.

Expected behavior

The newlines check should not include these file types.

Additional context or notes

Is there any way we can more broadly check for appropriate text files to which this should be applied and exclude all else?

Related: #4, #11

the-t-in-rtf commented 3 years ago

I will address all of these in #31.