search

fluid-project / fluid-lint-all

Consolidated linting logic free from any particular build technology
BSD 3-Clause "New" or "Revised" License
0 stars 5 forks source link

Need tests for newline exclusions. #31

Closed the-t-in-rtf closed 3 years ago

the-t-in-rtf commented 3 years ago

We added images to the default newline excludes a while back, but there are no real tests to confirm that all the image types are excluded, and to confirm that we can override this behaviour. Adding one of each excluded file type and then creating an alternate configuration that fails to exclude them should accomplish both.

the-t-in-rtf commented 3 years ago

Shockingly, in testing this I discovered that newline checks were only working if there were too many newlines at the end of the file, and not if there were none. Upgrading to the newest version of lintspaces addressed this.

the-t-in-rtf commented 3 years ago

Or not! I tested with a markdown file, markdownlint actually caught this, not lintspaces.newlines.

the-t-in-rtf commented 3 years ago

OK, that was terrifying, turns out that my fixtures were too short to trip the check, which I reported as a bug against node-lintspaces.