search

fluid-project / fluid-lint-all

Consolidated linting logic free from any particular build technology
BSD 3-Clause "New" or "Revised" License
0 stars 5 forks source link

Cannot install dependencies using npm@7. #35

Closed the-t-in-rtf closed 3 years ago

the-t-in-rtf commented 3 years ago

As discussed in #24, this package's dependencies can't be installed using npm@7 unless you use the --legacy-peer-deps flag, which is brought in by the stylelint-config-fluid dependency. That package is using the latest version of all its dependencies, but stylelint-config-recommended and others haven't been updated to work with newer versions of stylelint.

npm ERR! 
npm ERR! Found: stylelint@13.12.0
npm ERR! node_modules/stylelint-config-fluid/node_modules/stylelint
npm ERR!   stylelint@"13.12.0" from stylelint-config-fluid@0.2.0
npm ERR!   node_modules/stylelint-config-fluid
npm ERR!     stylelint-config-fluid@"0.2.0" from the root project
npm ERR!   peer stylelint@"^13.12.0" from stylelint-config-standard@21.0.0
npm ERR!   node_modules/stylelint-config-fluid/node_modules/stylelint-config-standard
npm ERR!     stylelint-config-standard@"21.0.0" from stylelint-config-fluid@0.2.0
npm ERR!     node_modules/stylelint-config-fluid
npm ERR!       stylelint-config-fluid@"0.2.0" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer stylelint@"^8.3.0 || ^9.0.0 || ^10.0.0" from stylelint-config-recommended@2.2.0
npm ERR! node_modules/stylelint-config-fluid/node_modules/stylelint-config-standard-scss/node_modules/stylelint-config-recommended
npm ERR!   stylelint-config-recommended@"^2.2.0" from stylelint-config-standard@18.3.0
npm ERR!   node_modules/stylelint-config-fluid/node_modules/stylelint-config-standard-scss/node_modules/stylelint-config-standard
npm ERR!     stylelint-config-standard@"~18.3.0" from stylelint-config-standard-scss@1.1.0
npm ERR!     node_modules/stylelint-config-fluid/node_modules/stylelint-config-standard-scss
npm ERR!       stylelint-config-standard-scss@"1.1.0" from stylelint-config-fluid@0.2.0
greatislander commented 3 years ago

@the-t-in-rtf I've replaced the dependency that was causing these issues, I think— I cut a dev release for testing. See https://github.com/fluid-project/stylelint-config-fluid/pull/9.

greatislander commented 3 years ago

Resolved in GH-40.

amb26 commented 3 years ago

But it isn't merged?

the-t-in-rtf commented 3 years ago

Sorry, I could have sworn we already addressed this, will research and clean up a bit.

the-t-in-rtf commented 3 years ago

Actually merged and released now. Mea culpa.