search

fluid-project / fluid-lint-all

Consolidated linting logic free from any particular build technology
BSD 3-Clause "New" or "Revised" License
0 stars 5 forks source link

Update to latest Fluid to resolve circular dependency warnings in node@14 #36

Closed the-t-in-rtf closed 3 years ago

the-t-in-rtf commented 3 years ago

Currently, using this package (for example, using npm run lint) throws warnings like the following:

(node:5218) Warning: Accessing non-existent property 'module' of module exports inside circular dependency
(Use `node --trace-warnings ...` to show where the warning was created)
(node:5218) Warning: Accessing non-existent property 'module' of module exports inside circular dependency
the-t-in-rtf commented 3 years ago

Updating our dependency reveals errors coming from other packages:

(node:5751) Warning: Accessing non-existent property 'module' of module exports inside circular dependency
    at emitCircularRequireWarning (node:internal/modules/cjs/loader:698:11)
    at Object.get (node:internal/modules/cjs/loader:712:5)
    at Object.<anonymous> (/Users/duhrer/Source/rtf/fluid-lint-all/node_modules/fluid-glob/node_modules/infusion/src/module/fluid.js:180:24)

(node:6180) Warning: Accessing non-existent property 'module' of module exports inside circular dependency
    at emitCircularRequireWarning (node:internal/modules/cjs/loader:698:11)
    at Object.get (node:internal/modules/cjs/loader:712:5)
    at Object.<anonymous> (/Users/duhrer/Source/rtf/fluid-lint-all/node_modules/markdownlint-config-fluid/node_modules/infusion/src/module/fluid.js:181:24)

If I manually hack their version and reinstall, the warnings disappear. I'll create pulls for each shortly.

greatislander commented 3 years ago

@the-t-in-rtf I've just published markdownlint-config-fluid@0.1.3 with your fix.