search

fluid-project / fluid-lint-all

Consolidated linting logic free from any particular build technology
BSD 3-Clause "New" or "Revised" License
0 stars 5 forks source link

GH-43: Add tests for custom lint check configuration options. (resolves #43) #44

Closed the-t-in-rtf closed 3 years ago

the-t-in-rtf commented 3 years ago

See #43 for details.

the-t-in-rtf commented 3 years ago

There are no code changes required, this just confirms that each configurable check can be configured and updates the docs. I probably will cut a new version, as I did also update the dependencies.

the-t-in-rtf commented 3 years ago

@greatislander, see the examples for stylelint configuration in this pull. I was hoping this would be enough to consider #28 resolved as well.

greatislander commented 3 years ago

@the-t-in-rtf at a glance this looks good— will try to review shortly. I believe @amb26 had filed #28 so he should have the final say on that one.

amb26 commented 3 years ago

Thanks for this work, @the-t-in-rtf - I verified that I could follow the instructions to override stylelint rules both internally and with an external config file. The new syntax checks are very helpful too - Cheers

the-t-in-rtf commented 3 years ago

Cheers. There were no functional changes, but I cut a new release just for the updated dependencies.