search

fluid-project / fluid-lint-all

Consolidated linting logic free from any particular build technology
BSD 3-Clause "New" or "Revised" License
0 stars 5 forks source link

Add ability to scan only staged files (resolves #62). #63

Closed duhrer closed 2 months ago

duhrer commented 8 months ago

See #62 for background.

duhrer commented 8 months ago

The test failure is a coverage failure, which completely makes sense, as I need to add tests.

duhrer commented 8 months ago

If anyone wants to try it, I cut a dev release, fluid-lint-all@1.2.10-dev.20231103T135559Z.3b3787c.GH-62. The new flag is --changedOnly.

duhrer commented 7 months ago

I found a handful of goofs with the new tests, this should be ready to review now.

duhrer commented 7 months ago

Per discussion with the group, it sounds like we wanted to lint "staged" files, which is now what this pull adds. I renamed the check to stagedOnly to clarify.

I released fluid-lint-all@1.2.10-dev.20231108T140350Z.5068e3f.GH-62 to assist in QA.

duhrer commented 7 months ago

@amb26, I have updated to avoid using mv directly in the tests, this should hopefully work on Windows as well.

amb26 commented 2 months ago

I'm currently unable to test this on my machine because of the following issue running the tests -

fluid-lint-all@1.2.11 test E:\Source\gits\fluid-lint-all npx nyc@15.1.0 node tests/all-tests.js

npm ERR! cb.apply is not a function

I get this with main as well so the issue isn't related to this pull - I've attached the logs 2024-04-09T14_49_52_581Z-debug.txt but will try again when I get back to my main machine.

node version 16.6.2 npm 6.14.11 on Windows

greatislander commented 2 months ago

Works for me, @duhrer! Thank you!