search

fluid-project / fluidproject.org

The Fluid Project website
http://fluidproject.org
13 stars 32 forks source link

The image at (https://fluidproject.org/projects.html) featured demos get disappeared when color and contrast in changed. #29

Open Chaitanyassr opened 4 years ago

Chaitanyassr commented 4 years ago

The image at (https://fluidproject.org/projects.html) featured demos get disappeared when color and contrast in changed.

To reproduce

Steps to reproduce the behavior:

  1. Go to https://fluidproject.org/projects.html by clicking on project on the main site.
  2. Click on preference
  3. change the color and contrast.
  4. See error

Screenshots

Screenshot (169)

jobara commented 4 years ago

These images are likely supplied as background images. UIO contrast options remove backgrounds images by default. Do we want to have keep these background images, remove them, keep them but change their colours, something else?

Chaitanyassr commented 4 years ago

These images are likely supplied as background images. UIO contrast options remove backgrounds images by default. Do we want to have keep these background images, remove them, keep them but change their colours, something else?

We can keep those images or we can also do something like github do for pinned repo, something very similer to this. chainging the color should not be an option as it would disrupt the look and feel. Screenshot (171)

jobara commented 4 years ago

@Chaitanyassr can you explain in more detail the suggestion that is similar to pinned repos on GitHub?

sachin10101998 commented 4 years ago

@jobara it's better if we keep these images even when contrast or theme is changed. Colour and Contrast options menu states that it is used to change text and background color. It's supposed to remove background colors and not images. Even in floeproject, the original images on the homepage stay even when we change contrast or theme.

sachin10101998 commented 4 years ago

This issue is similar to #28

Chaitanyassr commented 4 years ago

@Chaitanyassr can you explain in more detail the suggestion that is similar to pinned repos on GitHub?

As we can see in pinned section of github overview, repos(those we pinned) are organized inside the boxes. Its look quite aesthetic. We can do this for the featured demos(https://fluidproject.org/projects.html) were featured demos would be inside the same type of boxes.this would solve issue #28 #29.

sachin10101998 commented 4 years ago

@Chaitanyassr The background images disappear on changing themes because the background property explicitly sets the background to none. It's not because they are not inside the same types of boxes.

We can do this for the featured demos(https://fluidproject.org/projects.html) were featured demos would be inside the same type of boxes.this would solve issue #28 #29.

Can you elaborate on how putting those featured demos inside the same types of boxes will solve #28 and @29?

Chaitanyassr commented 4 years ago

@Chaitanyassr The background images disappear on changing themes because the background property explicitly sets the background to none. It's not because they are not inside the same types of boxes.

We can do this for the featured demos(https://fluidproject.org/projects.html) were featured demos would be inside the same type of boxes.this would solve issue #28 #29.

Can you elaborate on how putting those featured demos inside the same types of boxes will solve #28 and @29?

true, i totally agreed with the fact that background image can be kept. as @jobara asked of what we can do other that, so we can make a featured demo pannel like the one used for github pinned repo. Its not about the issue, its about replacing the whole featured demo thing while keeping #28 and #29 in mind.

sachin10101998 commented 4 years ago

@Chaitanyassr Correct me if I'm wrong but are you saying we remove the background images from default contrast theme too?