The updateSettings invoker provides a means for updating the settings model and providing an optional fall back to the default settings. However, in UIO+ this isn't used except for resetting, and even then the default settings are explicitly passed in. What's worse is that updateSettings provides no means of identifying a source.
Expected behavior
The updateSettings should be removed from UIO+ and the model updated declaratively through for resetting.
For UIO+ for Morphic related to GPII-4218 we also need to update the model. It would be handy to re-implement updateSettings there but also provide an explicit source. This will be needed to prevent cyclical updates of models being passed from Morphic to UIO+ for Morphic and back to Morphic.
Describe the bug
The
updateSettings
invoker provides a means for updating the settings model and providing an optional fall back to the default settings. However, in UIO+ this isn't used except for resetting, and even then the default settings are explicitly passed in. What's worse is thatupdateSettings
provides no means of identifying a source.Expected behavior
The
updateSettings
should be removed from UIO+ and the model updated declaratively through for resetting.e.g.
For UIO+ for Morphic related to GPII-4218 we also need to update the model. It would be handy to re-implement
updateSettings
there but also provide an explicit source. This will be needed to prevent cyclical updates of models being passed from Morphic to UIO+ for Morphic and back to Morphic.