search

fluidattacks / makes

A software supply chain framework powered by Nix.
https://makes.fluidattacks.tech/
MIT License
448 stars 43 forks source link

Consider deprecating MAKES_NON_ROOT #1357

Closed dsalaza4 closed 2 months ago

dsalaza4 commented 3 months ago

MAKES_NON_ROOT is only supported on a container level: https://github.com/fluidattacks/makes/blob/4e2e7ab3295e092237691336ec406273c54c3c4b/makes/container-image/main.nix#L135

This creates two m commands: One with MAKES_NON_ROOT support and another one without it.

If you try to reinstall makes via nix-env from the container, you end up with a Makes version that does not support MAKES_NON_ROOT. This creates strange behaviors that are very difficult to debug.

dsalaza4 commented 2 months ago

We will keep the makes user available so users can use it for tools that require to be executed with a non-root user.