search

fluidd-core / FluiddPI

FluiddPi - A Pi image with Klipper, Moonraker, Fluidd and Web Camera support pre-installed.
https://docs.fluidd.xyz
GNU General Public License v3.0
299 stars 58 forks source link

feat: enable moonraker object preprocessing #43

Closed matmen closed 2 years ago

matmen commented 2 years ago

In preparation for https://github.com/fluidd-core/fluidd/issues/359

pedrolamas commented 2 years ago

I've had a bit of second thoughts on this... wouldn't it make more sense to default the enable_object_processing to False and allow more advanced users to manually change it?

matmen commented 2 years ago

I think having it enabled by default makes sense for optimal user experience (no need for users to add a slicer post-processing script or manually toggle it on for object cancellation). What's the reason for having it disabled by default? And if it was disabled by default, we should probably add a docs page explaining the methods to enable object cancellation (and maybe even have gcode-viewer auto-loading turned off by default?).

pedrolamas commented 2 years ago

I'm just a bit mostly worried on the performance impact of users having this enabled and installing FluiddPi on a older Raspberry Pi, hence why I had second thoughts on this!

matmen commented 2 years ago

Fair. I honestly have no idea what the share of older (/ low performance) devices running FluiddPi looks like, and I don't know what the performance impact is on those. I may be able to test the performance impact (at least on a Pi 3, my Pi zero doesn't have WiFi), but I think having it opt-in is just fine too. What's your opinion on making auto loading in the gcode viewer-opt in too?

pedrolamas commented 2 years ago

What's your opinion on making auto loading in the gcode viewer-opt in too?

Yes, that makes sense to me!