search

fluidd-core / fluidd

Fluidd, the klipper UI.
https://docs.fluidd.xyz
GNU General Public License v3.0
1.37k stars 420 forks source link

Cannot cancel GCode preview loading when using "Automatically load file on print start" #1003

Closed leoshusar closed 1 year ago

leoshusar commented 1 year ago

Fluidd Version

1.22.2

Browser

Chrome

Device

Desktop PC, Mobile device (Phone, Tablet or similar)

Operating System

Windows, Android

What happened

I am using GCode preview and I have enabled "Automatically load file on print start". Sometimes when I'm checking from my phone using mobile data, I want to cancel that preview download, because my data plan has limited speed and I only want to quickly check the webcam. However it's currently impossible to cancel it, the dialog just reappears and the download continues (with NaN as remaining download size).

https://user-images.githubusercontent.com/13891066/210394523-045dd0b8-5121-4aa7-a83d-59456dbe36c8.mp4

What did you expect to happen

Downloading should stop

How to reproduce

Additional information

No response

Matrixchung commented 1 year ago

The same issue even occurs when "Automatically load file on print start" is disabled and all "Gcode preview" settings are default. After clicked the "cancel" button, the download dialog just reappears with a total file size of "NaN KB".

pedrolamas commented 1 year ago

Thanks, I've managed to reproduce and confirm this bug. We will try to fix this on the next Fluidd release.