fluidd-core / fluidd

Fluidd, the klipper UI.
https://docs.fluidd.xyz
GNU General Public License v3.0
1.37k stars 421 forks source link

[gcode preview] failure to parse gcode sliced with Cura 5.3.0 #1068

Closed chelli closed 1 year ago

chelli commented 1 year ago

Fluidd Version

1.23.3

Browser

Chrome

Device

Desktop PC, Laptop

Operating System

Linux

What happened

Since switching from Cura 5.2.2 to the most recent stable release 5.3.0, fluidd gcode preview fails to parse the gcode.

See the attached gcode files as an example: FQ5_square.zip

When trying to load the file, fluidd shows the following and it does not proceed anymore: Bildschirmfoto vom 2023-03-16 21-01-25

What did you expect to happen

Fluidd should properly load the gcode files into the gcode preview.

How to reproduce

Please try to load the attaced (zipped) gcode file into the gcode preview.

Additional information

No response

pedrolamas commented 1 year ago

Thanks for reporting this @chelli, I have managed to repro this issue, although it seems more related with the preprocess_cancellation script output (if enabled on moonraker.conf, this is run automatically on g-code file upload)

Here we can see an EXCLUDE_OBJECT_DEFINE entry without any POLYGON or even CENTER attributes.

image

And this is what Fluidd shows when printing this file:

image

I'm not sure what this "NOMESH" object is or how it got into your gcode... could this be some plugin you are using in Cura?

pedrolamas commented 1 year ago

I've found this reference on Cura: https://github.com/Ultimaker/Cura/issues/14679#issuecomment-1446307269

Seems to be a typo in Cura 5.3 Beta 1, so I would expect this to have been fixed on the final Cura 5.3 release.

pedrolamas commented 1 year ago

Here's the open PR on Cura repo to fix this issue: https://github.com/Ultimaker/CuraEngine/pull/1855

pedrolamas commented 1 year ago

Although this issue still needs to be fixed in Cura (as this is their issue!), I've added a fix for the next release of Fluidd.

Until there, to mitigate this issue I recommend that after uploading a g-code file from Cura 5.3, you edit the file in Fluidd, remove the line `EXCLUDE_OBJECT_DEFINE NAME=NOMESH", and save the result.