search

fluidd-core / fluidd

Fluidd, the klipper UI.
https://docs.fluidd.xyz
GNU General Public License v3.0
1.37k stars 421 forks source link

feat(spoolman): QR code scanning support #1149

Closed matmen closed 1 year ago

matmen commented 1 year ago

As described in https://github.com/fluidd-core/fluidd/pull/1119

Adds support for spoolman QR codes (https://github.com/Donkie/Spoolman/issues/10). Adds an option to automatically commit a spool selection when a valid QR code is scanned (no need to manually confirm the selection) Adds support for using the device's camera as a scan source (https://github.com/fluidd-core/fluidd/pull/1119#issuecomment-1676159359) Closes https://github.com/fluidd-core/fluidd/issues/1151

matmen commented 1 year ago

@NonaSuomy Feel free to test these changes, I just added support for using the device's camera as a scan source

pedrolamas commented 1 year ago

@matmen To fix #1150, I made crossorigin an optional property, so you will need to add crossorigin="anonymous" to this element

Having said that we now know that this will still fail if the streaming server is not setting the Access-Control-Allow-Origin "*" response header... in that case the DOMException that you are already catching will have ex.name === "SecurityError"

pedrolamas commented 1 year ago

And while we're at it, we might want to add #1151 here?