search

fluidd-core / fluidd

Fluidd, the klipper UI.
https://docs.fluidd.xyz
GNU General Public License v3.0
1.38k stars 423 forks source link

Ability to reset Thermals Graph to clear erroneous RTD Amplifier temperatures during Amplifier initialization #1169

Open ChaosBlades opened 1 year ago

ChaosBlades commented 1 year ago

Is your feature request related to a problem? Please describe

When you use an RTD Amplifier such as the MAX31865 on the BTT EBB36 you will get erroneous temperature readout during that chips initialization. This behavior can be reproduced simply by initiating a FIRMWARE_RESTART. Would be nice if you could avoid the Thermals Graph becoming useless as these readings re-scale the graph to uselessness.

Edit: This is not triggered via FIRMWARE_RESTART. It is triggered via SAVE_CONFIG. Also https://github.com/Klipper3d/klipper/pull/6320 did not resolve the issue.

Describe the solution you'd like

Ability to clear the graph information without having to reboot the printer.

Describe alternatives you've considered

Ability to set scaling limits for the graph.

Additional information

Screenshot from 2023-09-08 00-24-54 Screenshot from 2023-09-08 00-27-56

pedrolamas commented 1 year ago

Hi @ChaosBlades thank you for reporting this.

I agree, this is a really bad experience (though it is one outside of Fluidd control), but I have to admit I am a bit skeptical in doing such a fix in Fluidd as it feels a bit that this should be done upstream in Moonraker or even Klipper!

I will discuss this with the other devs and see what we can do to improve this.

ChaosBlades commented 5 months ago

@pedrolamas Looks like this isn't going to happen upstream. Moonraker wants Klipper to fix this. I posted to the Klipper forum and got no useful responses to this issue.

https://klipper.discourse.group/t/erroneous-rtd-amplifier-temperatures-during-amplifier-initialization-when-save-config/15022/2

Can we just add an option in Settings to limit the min/max scaling values in the graph? So it scales like normal up to the values defined. So I would probably set 300C Max and -10C Min.