Closed vajonam closed 9 months ago
Thanks for your PR, I think the changes look nice. I've left a few comments in my review above
@matmen that pushes the percentage wrapper, not sure how to address that?
should be sorted now!
@matmen can you test this latest commit, because it makes up much less room, I am proposing we used in mdAndUp breakpoints.
I've made some tweaks and simplified the styles, will perform some more tests to ensure I haven't broken anything before merging down.
please add a setting for this, i want to use the "old" layout. my thumbnails contain information in each corner which the new layout cuts off
can you post a screenshot of the old layout with your thumb info? just curious to see.
@vajonam: can you post a screenshot of the old layout with your thumb info? just curious to see.
here is an example of thumbnail elegoo cura is generating for each sliced model. if you put it inside a circle, you lose all the useful details (filament grams used and cost as the others are in fluidd already).
how it looks in fluidd now:
how it looked before:
i think its obvious which one was better (at least for me and elegoo users). there is also no saved space so i don't get this change at all
please add a setting toggle for this layout change. thanks!
I disagree there is no saved space, in the cases where there is longer filename it helps with the layout. However, I understand your issue. click on the thumbnail, will bring up full thumb. I get the issue.
@rursache I personally wasn't aware of this possibility though I can perfectly see your point.
I've discussed this with @vajonam and we are going to add an option to pick between the "classic" layout (the existing one where progress and thumbnail is separate) and the new "compact" layout (that matches the changes on this PR), that way users can choose which one is better for their purposes.
@pedrolamas & @vajonam thank you for your effort and consideration!
@pedrolamas was the option added? where can i find it and switch to the old layout? thanks
hi just wanted to share ideas • moved percentage to title bar • used progress bar at full length below title bar and this allows to using gcode preview bigger • added exclude as button. button type is different before
@pedrolamas was the option added? where can i find it and switch to the old layout? thanks
Just created the PR!
hi just wanted to share ideas • moved percentage to title bar • used progress bar at full length below title bar and this allows to using gcode preview bigger • added exclude as button. button type is different before
looks great!
@pedrolamas was the option added? where can i find it and switch to the old layout? thanks
Just created the PR!
amazing!
one possible alternate layout for the status panel.
Before
After
Fixes #1251 Fixes #1211
Signed-off-by: vajonam 152501+vajonam@users.noreply.github.com