Tool change macro with active=True is not highlighting the active tool

[viesturz]

Fluidd Version

v1.26.3

Browser

Chrome

Device

Desktop PC

Operating System

Windows

What happened

I'm trying to get the active tool button to have a different color, as per the screenshot in https://github.com/fluidd-core/fluidd/pull/1111

What did you expect to happen

The acttive tool should be highlighted.

How to reproduce

Create Gcode macros for T0, T1, T2, etc.

[gcode_macro T0]
variable_active: True
gcode:
  SELECT_TOOL T=0

Expecting this to highlight the button. But it's the same as others.

~~ Also tried adding the variable_color: "F00" but no effect. The only option that works is variable_color: "FF0000"~~ Checked again, F00 works fine.

Additional information

No response

[viesturz]

Also colors for T0 and T1 are not working at all on one printer, but fine on another. Some config corruption?

[viesturz]

[pedrolamas]

Hi @viesturz, thanks for opening this issue.

I should point out that what you see in #1111 is actually just an example, it does not represent the "active" tool... Fluidd does not highlight the current tool, but I will change this ticket to Feature Request so we can look into this.

As for the missing color, can I ask that you post your Tx macros here so I can take a look?

[viesturz]

My macros are super simple

[gcode_macro T0]
variable_color: "f00"
gcode:
  SELECT_TOOL T=0

[gcode_macro T1]
variable_color: "f00"
gcode:
  SELECT_TOOL T=1

Etc.

As I said, only T0 and T1 are not updating the color, and only one printer out of 2, so likely some snafu on my side.

[pedrolamas]

@viesturz that looks ok to me... I would check if you have some hidden spaces on that which could cause this issue.

Having said that, Fluidd does not keep what tool is active, that is up to your macros to do (each Tx macro needs a variable_active: False or True to set the active state).

[viesturz]

Yes I know that. Just was expecting that the active parameter is actally used, since it is populated in the code of #1111.

Digging into the web traffic, and this is wierd. I changed the configs back to empty string colors (with a macro to override it on toolchange). But for T0 and T1 the variables have active=. Which I was experimenting with some hours ago, but now they should be removed. WTF?

Request:

http://192.168.86.38/server/database/item?namespace=fluidd

Response:

"macros": {
                "stored": [
<snip>
              {
                        "name": "t0",
                        "alias": "",
                        "visible": false,
                        "disabledWhilePrinting": true,
                        "color": "",
                        "categoryId": "0",
                        "variables": {
                            "active": false
                        }
                    },
                    {
                        "name": "t1",
                        "alias": "",
                        "visible": false,
                        "disabledWhilePrinting": false,
                        "color": "",
                        "categoryId": "0",
                        "variables": {
                            "active": true
                        }
                    },
                    {
                        "name": "t2",
                        "alias": "",
                        "visible": false,
                        "disabledWhilePrinting": false,
                        "color": "",
                        "categoryId": "0",
                        "variables": {
                            "color": ""
                        }
                    },
                    {
                        "name": "t3",
                        "alias": "",
                        "visible": false,
                        "disabledWhilePrinting": false,
                        "color": "",
                        "categoryId": "0",
                        "variables": {
                            "color": ""
                        }
                    },
]

The printer objects status over the websocket is correct however.

gcode_macro T0: {color: ""}
gcode_macro T1: {color: "c44"}
gcode_macro T2: {color: ""}
gcode_macro T3: {color: ""}
gcode_macro T4: {color: ""}
gcode_macro T5: {color: ""}

[viesturz]

Awesome, thanks;

On Fri, Dec 8, 2023, 12:13 Pedro Lamas @.***> wrote:

Closed #1261 https://github.com/fluidd-core/fluidd/issues/1261 as completed via #1263 https://github.com/fluidd-core/fluidd/pull/1263.

— Reply to this email directly, view it on GitHub https://github.com/fluidd-core/fluidd/issues/1261#event-11192329324, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAMQT46TUVVOFJE2EIIGNM3YILY6PAVCNFSM6AAAAABALQBZ32VHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJRGE4TEMZSHEZTENA . You are receiving this because you were mentioned.Message ID: @.***>