fluidd-core / fluidd

Fluidd, the klipper UI.
https://docs.fluidd.xyz
GNU General Public License v3.0
1.35k stars 410 forks source link

Toolhead distance not updating correctly #1285

Closed thijstriemstra closed 8 months ago

thijstriemstra commented 8 months ago

Fluidd Version

1.27

Browser

Firefox

Device

Desktop PC

Operating System

Windows, macOS

What happened

I defined following distances:

tool3

Switching back to dashboard shows incorrect values:

tool1

Clicking one of them renders values correctly:

tool2

What did you expect to happen

Display correct values.

How to reproduce

See above.

Additional information

No response

pedrolamas commented 8 months ago

Hi @thijstriemstra, thanks for opening this issue.

I am aware of this behavior (truth be told, we coded it like that), and it is due to the fact that if the user removes the current distance value from the available ones, we are adding it back as a temporary one, that will disappear once the user picks one from the list.

Granted, this behavior is quite weird, and I am will be happy to change it (probably will just pick the smallest from the available list in those cases)

thijstriemstra commented 8 months ago

Granted, this behavior is quite weird,

Yea, when I click 500 in above example, it will switch to the new button layout, and select 250 instead (because of the re-ordering or something), making me have to click 500 again in order to properly select it.

thijstriemstra commented 8 months ago

A side note; the max distances that can be defined is 6, any chance this could be arbitrary?

pedrolamas commented 8 months ago

We limited the number of values as we know that it can screw the layout of the page.

thijstriemstra commented 8 months ago

it can screw the layout of the page.

I see, but I would honestly not care, it's the functionality I'm after.. So if items > 6, page is screwed up, call it a known issue..

pedrolamas commented 8 months ago

I assume that when you removed the 1 from the list, the "Default toolhead move length" went blank (which is because the value previously selected got removed)

image

Does this match what you are seeing?

thijstriemstra commented 8 months ago

Ah yes, it appears to be blank:

afbeelding