search

fluidd-core / fluidd

Fluidd, the klipper UI.
https://docs.fluidd.xyz
GNU General Public License v3.0
1.35k stars 410 forks source link

feat(i18n-ko): Update Kor translations #1289

Closed crwusiz closed 8 months ago

pedrolamas commented 8 months ago

Hi @crwusiz thank you for sending this Pull Request.

I have a small problem though, as I now have a colliding translation to merge that was provided a few hours before here by @SangJin521

I do see some differences in terms such as the translation for "base" or "actual", so I am unsure which is "more" correct here...

Can I ask you both for help to get this to a common ground?

For what is worth, the current advice is for translations to be provided via weblate, as that will make it easier to merge.

crwusiz commented 8 months ago

Hi @crwusiz thank you for sending this Pull Request.

I have a small problem though, as I now have a colliding translation to merge that was provided a few hours before here by @SangJin521

I do see some differences in terms such as the translation for "base" or "actual", so I am unsure which is "more" correct here...

Can I ask you both for help to get this to a common ground?

For what is worth, the current advice is for translations to be provided via weblate, as that will make it easier to merge.

Compared to the en.yaml file, I added and translated a string that was not there, but there was a translation method using weblate.

@sangjin521 posted the translation work first. I checked and found that there are many strings that have not been translated yet, so I will revise the translation further on the weblate

pedrolamas commented 8 months ago

Replaced by #1288