fluidd-core / fluidd

Fluidd, the klipper UI.
https://docs.fluidd.xyz
GNU General Public License v3.0
1.35k stars 410 forks source link

Language commit history incorrect #1293

Closed thijstriemstra closed 7 months ago

thijstriemstra commented 8 months ago

Fluidd Version

1.27.1

Browser

Firefox

Device

Desktop PC

Operating System

Windows

What happened

Language is set to English:

afbeelding

But I'm seeing Dutch in the commit history panel (gisteren and eergisteren):

afbeelding

What did you expect to happen

Honour language setting and ignore browser/os language.

How to reproduce

Use a non-english browser to view commit history.

Additional information

No response

pedrolamas commented 8 months ago

Hi @thijstriemstra, thanks for opening this issue.

Can you check if changing to another language and then back to English solves the problem?

thijstriemstra commented 8 months ago

I'll have to check once moonraker or klipper has an update again, can't access panel without updates.

thijstriemstra commented 7 months ago

changing to another language and then back to English solves the problem?

pedrolamas commented 7 months ago

Can you try opening in an anonymous browser window?

If it shows with no problem on the anonymous window, I recommend that performing a full refresh of Fluidd (clearing the browser cache)

thijstriemstra commented 7 months ago

(clearing the browser cache)

I'm doing that everytime already.

Can you try opening in an anonymous browser window?

Yep but will have to wait for klipper/moonraker updates again first, since I just updated 😋

thijstriemstra commented 7 months ago

Tested again, and a private firefox window didn't make a difference.

pedrolamas commented 7 months ago

I might know what is at play here, let me do some checks and I will report back when I can...

pedrolamas commented 7 months ago

I did a quick test on this and now I recall that we are using the browser locale to format dates & times, so I assume your main browser language is Dutch?

thijstriemstra commented 7 months ago

yea it's dutch