fix: don't override `gcode_macro` variables with stale values

fluidd-core / fluidd

Fluidd, the klipper UI.

https://docs.fluidd.xyz

GNU General Public License v3.0

1.34k stars 401 forks source link

fix: don't override `gcode_macro` variables with stale values #1355

Closed matmen closed 5 months ago

matmen commented 5 months ago

When a macro is edited via the UI it saves a copy of it in the database, which is then used to override some default settings. It looks like this also overrides the macros variables, so they will never change as far as the UI is concerned.

Fixes #1269 not showing up

pedrolamas commented 5 months ago

Indeed, this will fix this specific problem, but I have a feeling we are storing more than we should on the database (probably because of some of my refactorings...)

matmen commented 5 months ago

Yep, I agree - we should only be storing the values that can actually be changed through the UI..