fluidd-core / fluidd

Fluidd, the klipper UI.
https://docs.fluidd.xyz
GNU General Public License v3.0
1.39k stars 424 forks source link

fix: make color picker use v-model and propsync #1375

Closed pedrolamas closed 7 months ago

pedrolamas commented 7 months ago

This PR refactors the AppIroColorPicker and AppColorPicker to use v-model and propsync where possible, thus making the control easier to consume, and fixing the reported issue.

Note: following up on what we already do with our custom input controls, changing the value on the text input boxes will not take effect unless Enter is pressed.

Fixes #1372

pedrolamas commented 7 months ago

@matmen I know you also have an incoming PR with work on this area, I made it easy to integrate your changes in this one (just by using the new currentRed, currentGreen, currentBlue and currentWhite props)

pedrolamas commented 7 months ago

Oops, I forgot to change those @change to @input... I just send a new commit da41abe that from me tests fixes the issue!