search

fluidd-core / fluidd

Fluidd, the klipper UI.
https://docs.fluidd.xyz
GNU General Public License v3.0
1.34k stars 399 forks source link

feat: add finish time selection from slicer or file #1378

Closed MadeBaruna closed 4 months ago

MadeBaruna commented 4 months ago

added options on general setting with file or slicer for finish time and progress close #1373

image

file: 20240302-185332517

slicer: 20240302-185349605

pedrolamas commented 4 months ago

Hi @MadeBaruna, thank you for your work on this Pull Request, this was an absolute stellar job! 🙂

I made a couple of changes to it, but the most important is that I added the possibility to select more than one data source for the Print Progress and Print ETA (so when more than one is selected, we will display an average)

pedrolamas commented 4 months ago

Here's how it currently looks on the settings side:

image

yw4z commented 3 months ago

@pedrolamas what about adding an average of both as option

pedrolamas commented 3 months ago

what about adding an average of both as option

@yw4z just tick both checkboxes and it will calculate an average! 🙂

yw4z commented 3 months ago

@pedrolamas nice to see you already added but using a radio button with separate options would be better to show there is an average option. also i will share a detailed design mockup soon for print status section :) which section is best to share at discussion / issues

pedrolamas commented 3 months ago

@yw4z it literally says so on the description, not sure what else we could do here to improve it... 🤔

image

yw4z commented 3 months ago

@pedrolamas people like me don't read much i guess :)