fluidd-core / fluidd

Fluidd, the klipper UI.
https://docs.fluidd.xyz
GNU General Public License v3.0
1.34k stars 399 forks source link

feat: adds support for machine peripherals #1383

Closed pedrolamas closed 3 months ago

pedrolamas commented 4 months ago

Adds support for the new Moonraker Machine Peripherals (Devices)

CAN bus tab will appear if one or more CAN interfaces exist -> this bit has not been thoroughly tested as I do not have a CAN network myself that I can use for testing purposes.

Shortcut on system info card

image

Shortcut on file editor

image

On open

image

After refresh, no devices found

image

After refresh, serial devices found

image

After refresh, usb devices found

image

Resolves #1290

pedrolamas commented 4 months ago

I am still iterating on the UI of this (trying expander panels, tabs, etc.), but this is what I am thinking in terms of dialog with expander panels:

All collapsed

image

Serial expanded

image

USB expanded

image

pedrolamas commented 4 months ago

I honestly am a bit on a lost with how best to show this dialog and that it would look good in both desktop and mobile... for copy-paste I will probably just add some buttons on the values, but the whole look/organization of it is what I am more on a loss.

The expanders (as shown above) look a bit weird when they are all collapsed... Mainsail went for tabs, I am not fully on board with that too...

thijstriemstra commented 4 months ago

The expanders (as shown above) look a bit weird when they are all collapsed..

what about using tabs instead?

thijstriemstra commented 4 months ago

some device names can be quite long,

e.g. a BTT U2C v2.1 shows up as OpenMoko, Inc. Geschwister Schneider CAN adapter with lsusb:

Bus 001 Device 005: ID 1d50:606f OpenMoko, Inc. Geschwister Schneider CAN adapter
pedrolamas commented 3 months ago

Tabs seem to be ok'ish...

On open

image

After refresh, no devices found

image

After refresh, devices found

image