fluidd-core / fluidd

Fluidd, the klipper UI.
https://docs.fluidd.xyz
GNU General Public License v3.0
1.34k stars 399 forks source link

feat: adds keyboard shortcuts #1404

Closed pedrolamas closed 3 months ago

pedrolamas commented 3 months ago

Adds support for keyboard shortcuts!

Keyboard Shortcuts dialog (shown with ?)

image

image

Button tooltips (shown only if Keyboard Shortcuts are enabled)

image

image

image

Settings entry

image

matmen commented 3 months ago

Both the pause and cancel shortcuts conflict with some firefox shortcuts (new private window and element picker respectively), and while Ctrl+Shift+C seems to work fine when printing (only opens the element picker when the printer is idle), Ctrl+Shift+P always opens a new private window for me

pedrolamas commented 3 months ago

I have a feeling I am opening a can of worms here... I'm going to check the keyboard shortcuts that Gmail uses and try to use those (should be safer, I guess...)

pedrolamas commented 3 months ago

I've set Pause to Shift+p and Cancel to Shift+c, seems to work fine in Chrome/Edge and Firefox...


I now got myself thinking... arrows to control the toolhead? 😁

Like Shift+arrow key and that would move the toolhead in the indicated direction by 10mm?

matmen commented 3 months ago

I've set Pause to Shift+p and Cancel to Shift+c, seems to work fine in Chrome/Edge and Firefox...

With just Shift+P and Shift+P I now can't type any upper case commands containing a C or P in the console while a print is running ;) I assume the event handler is just missing the eventTargetIsContentEditable call tho 😁

I now got myself thinking... arrows to control the toolhead? 😁

Like Shift+arrow key and that would move the toolhead in the indicated direction by 10mm?

I guess that could work - maybe it could even use the configured move distances using the number keys, but that'd be a lot of combinations to remember haha

pedrolamas commented 3 months ago

With just Shift+P and Shift+P I now can't type any upper case commands containing a C or P in the console while a print is running ;) I assume the event handler is just missing the eventTargetIsContentEditable call tho 😁

Oops... fixed now! 🙂