fluidd-core / fluidd

Fluidd, the klipper UI.
https://docs.fluidd.xyz
GNU General Public License v3.0
1.39k stars 424 forks source link

fix(gcodepreview): ignore moves without coordinates #1416

Closed pedrolamas closed 5 months ago

pedrolamas commented 5 months ago

I've noticed that some files sliced by Orca Slicer have G0/G1 commands without any X, Y, Z, or E change.

Though I am not sure why these commands exist, the fact is that this introduced a bug on the Gcode Previewer, where these moves would cause extra extrusion markers to apper.

The fix here is to ignore any G0/G1/G2/G3 command that does not include at least one of the necessary coordinates change arguments.

This also includes a minor fix for the previewer code where retractions where incorrectly being checked for extrusions.

Before

image

After

image