fluidd-core / fluidd

Fluidd, the klipper UI.
https://docs.fluidd.xyz
GNU General Public License v3.0
1.33k stars 398 forks source link

Login in PC version has invisible symbol #1421

Closed SlimRG closed 1 month ago

SlimRG commented 2 months ago

Fluidd Version

v1.29.1-fef6e12

Browser

Chrome

Device

Desktop PC, Mobile device (Phone, Tablet or similar)

Operating System

Linux, Android

What happened

When I create account on PC - I can join on PC But when I connect local mobile and see invisible on PC symblol.

What did you expect to happen

image And also, when I create account on mobile without this symbol - I can't connect by PC

How to reproduce

Try to create and login by mobile and by pc without localhost

Additional information

No response

pedrolamas commented 2 months ago

Hi @SlimRG , thank you for opening this ticket.

I am however having trouble identifying where in Fluidd was this screenshot taken from.

Can you please identify where this is from and maybe post a larger screenshot?

SlimRG commented 2 months ago

From PC: image From Android: image

SlimRG commented 2 months ago

Upper login was created by phone, another - by PC with MS Edge

pedrolamas commented 2 months ago

I am unsure of what has happened here... while it looks like you have 2 accounts with the same username, that is not the case as Moonraker would not allow duplicate accounts.

I am unsure of what this user character is, but my advice would be to remove the account and create it again.

SlimRG commented 2 months ago

I made two accounts to login by phone and by PC

SlimRG commented 2 months ago

For PC I made on PC and didn't see any invisible symbols. But when I tried to connect by phone - I can't login with my login (SlimRG) So, I created second account through trusted user by phone with no invisible symbols. It's not a big problem to have two accounts (for PC and Phone) But, it's a bug, that you can reproduse. Oh, I forgot to say, PC on Linux (KDE Neon)

SlimRG commented 2 months ago

As I think, you can trim login string and convert to ASCII format

SlimRG commented 2 months ago

I reinstall fluidd - the same problem

pedrolamas commented 2 months ago

I have been unable to reproduce this issue with either my Windows PC running MS Edge, or on my Android phone also running MS Edge...

The only reason I see for this thing to happen would be if some browser extension is doing something to change the content of the data submitted!

Can I ask that you access http://<moonraker-host>:715/access/users/list and paste the response here?

SlimRG commented 2 months ago

{"result": {"users": [{"username": "SlimRG", "source": "moonraker", "created_on": 1713889753.240955}, {"username": "SlimRG\u007f", "source": "moonraker", "created_on": 1713896388.1075256}, {"username": "Test", "source": "moonraker", "created_on": 1714075482.5925968}]}}

Sorry for waiting, was at county house (took a break from work)

SlimRG commented 2 months ago

I have been unable to reproduce this issue with either my Windows PC running MS Edge, or on my Android phone also running MS Edge...

The only reason I see for this thing to happen would be if some browser extension is doing something to change the content of the data submitted!

Can I ask that you access http://<moonraker-host>:715/access/users/list and paste the response here?

I have extensions LastPass and AdGuard. But on other sites I had no problems with invisible symbol in login. Hmmm...

pedrolamas commented 2 months ago

The \u007f character above is the Delete control character... not sure what is going on here, but the browser seems to have entered that in one of the usernames!

pedrolamas commented 1 month ago

I haven't been able to reproduce this issue. I have only tested in Windows, but my gut feeling is that KDE input is somehow at play here as the \u007f character is the Delete control character - which should not feature on the input.

Nevertheless, I don't think this is a Fluidd issue and will now close this ticket, but keep an eye on for any other user having similar issues.