fluidd-core / fluidd

Fluidd, the klipper UI.
https://docs.fluidd.xyz
GNU General Public License v3.0
1.33k stars 398 forks source link

Add bulk job delete to web UI #1426

Closed MohnJadden closed 2 months ago

MohnJadden commented 2 months ago

Is your feature request related to a problem? Please describe

We have to click on a job -> click on Remove -> click Confirm when we want to delete a gcode file as a job. Doing this for multiple files is a long, drawn-out process when there are multiple files to delete.

Describe the solution you'd like

A column should be added to the Jobs window with a checkbox for each job. We should be able to check off the checkbox for each job we want to delete, then click a Delete button (similar to how we have Filter and Add buttons) to delete the selections. The confirmation dialog should reflect that we want to delete X number of selected jobs, where X = the number of checkboxes checked.

Describe alternatives you've considered

SSHing into the printer and deleting by file name (not practical, since we would have to engage in the same manual process, if not longer)

SSHing into the printer and finding some way to script deletion (I am not a programmer and wouldn't know where to begin)

Deleting jobs as we go (not practical if you're sending multiple iterations of a file after each one completes - e.g. testing, batch jobs, etc.)

Additional information

No response

pedrolamas commented 2 months ago

Hi @MohnJadden thanks for opening this ticket.

I am however not sure if you are aware that on the Jobs page we do have the full support for batch move & delete of jobs and folders:

image

MohnJadden commented 2 months ago

Thank you for pointing that out - I wasn't aware.

Would it be possible to apply this setting to the Jobs menu on the Home page?

pedrolamas commented 2 months ago

Would it be possible to apply this setting to the Jobs menu on the Home page?

Short answer is no; the Dashboard on the main page uses a more compact view, mostly for mobile view but also to make it a bit more "light".

MohnJadden commented 2 months ago

It seems like having the checkbox wouldn't take up too much if it's at the far right - everything would just get indented by X pixels.

It's not a horrible loss to not have it but if it's an onerous burden to code it in without sacrificing too much from mobile, it would be wonderful to have it on the home page.

If not, I am grateful that it's present somewhere, thank you for pointing it out!

pedrolamas commented 2 months ago

It's not just the width that would get smaller due to the introduction of the checkbox, but also the height of the entries: we currently use the "compact" view of the list on the Dashboard (items has smaller fonts and margins, so each row is actually a bit smaller in height).

Layout is very tricky, especially on the myriad of mobile devices available, so for the moment, there are no plans to introduce the checkboxes in the Dashboard view, and have them only on the Jobs page.