search

fluidd-core / fluidd

Fluidd, the klipper UI.
https://docs.fluidd.xyz
GNU General Public License v3.0
1.33k stars 398 forks source link

feat: show print progress when status panel is collapsed #1445

Closed matmen closed 1 month ago

matmen commented 1 month ago

Adds a linear print progress bar to the status panel when it's collapsed, so the current progress is always visible

Before grafik

After grafik

Closes #1432

matmen commented 1 month ago

not sure what happened in commit https://github.com/fluidd-core/fluidd/pull/1445/commits/8c651f46dded0064a76e04bd193f2885ddd037dd, i think i may have committed the wrong file ;) will take a look at it when i get home

pedrolamas commented 1 month ago

I had previously taken a quick stab at this and stopped when I noticed that it would break the corners style... seems you are hitting the same issue here:

image

matmen commented 1 month ago

Yep! I fixed that locally (should have been commit https://github.com/fluidd-core/fluidd/commit/8c651f46dded0064a76e04bd193f2885ddd037dd), but looks like I pushed the wrong file. I'll push the correct one when I get home and let you know 😉

matmen commented 1 month ago

@pedrolamas should be good to go :) image

matmen commented 1 month ago

well, looks like there still is some kind of bug related to the v-if in the slot template. for whatever reason the hasCollapsedContentSlot getter only gets called on component initialization, but not when the isCollapsed state changes, resulting in unexpected behavior. changing the getter to a function fixes this, but also makes vue re-evaluate the expression every second or so, not sure if that's just because of the component re-rendering tho..

edit: well, this makes sense: "Please note that slots are not reactive". should be fixed in https://github.com/fluidd-core/fluidd/pull/1445/commits/02cb0c1575eb11c3837aff31a31155d20eba8b77