search

fluidd-core / fluidd

Fluidd, the klipper UI.
https://docs.fluidd.xyz
GNU General Public License v3.0
1.33k stars 398 forks source link

Default "Camera Url Stream" is not user-friendly for WebRTC (camera-streamer). #1453

Closed zhou13 closed 2 weeks ago

zhou13 commented 2 weeks ago

Is your feature request related to a problem? Please describe

I spend quite a bit of time to get the WebRTC (camera-stream) working. There are two problems:

  1. The URLs does not default to hostname:8080, but hostname:80;
  2. The default suffix is /webcam/?action=stream, instead of /webrtc

Describe the solution you'd like

I hope the following things becomes the default:

Screenshot 2024-06-17 at 10 41 32 PM

Describe alternatives you've considered

No response

Additional information

No response

pedrolamas commented 2 weeks ago

Hi @zhou13, thank you for opening this ticket.

For the record, the current defaults we use here are to for the MJPEG Streamer, not the WebRTC streamer.

There is no way we can present any sensible defaults on this as we have no idea what streamer the user is going to use, what host, port, path, etc... It will be up to the end user to specify these details.

I should point out that I can see "fluiddpi" in your screenshot which we have discontinued a long time ago, so we can't even take that as a default.

zhou13 commented 2 weeks ago

I should point out that I can see "fluiddpi" in your screenshot which we have discontinued a long time ago, so we can't even take that as a default..

@pedrolamas I just installed a new Raspbian OS with kiauh and I just use fluiddpi as a hostname for backward compatibility. Since it is just a hostname and hostname can be anything, I think it is irrelevant for the discussion here.

For the record, the current defaults we use here are to for the MJPEG Streamer, not the WebRTC streamer. There is no way we can present any sensible defaults on this as we have no idea what streamer the user is going to use, what host, port, path, etc... It will be up to the end user to specify these details.

As you can see in the screenshot, it clearly says that the selected streamer for the WebRTC is "camera-streamer", not "MJPEG Streamer". In addition, MJPEG streamer, as its name states, does not even support WebRTC! It is better to provide reasonable default that works for the selected WebRTC (camera-streamer).

In addition, I found "Camera Url snapshot" is also confusing in the context of WebRTC. Is it necessary for WebRTC?

pedrolamas commented 2 weeks ago

Apologies, I shouldn't have made assumptions made on the hostname.

Regarding the defaults, I am considering removing them completely in order not to create any confusion going forward.

The screenshot URL is still used if you are using timelapse functionality (and should be set as on mjpeg streamer)

zhou13 commented 2 weeks ago

Thank you! I agree that completely removing them will be a better defaults.