Closed rmcfadzean closed 1 month ago
Hi @rmcfadzean, thank you for opening this ticket.
I am not sure I fully understand the problem here, can you provide a concrete snippet of [update_manager led-effect]
section you are using and how is the folder structure for this repo in your file system?
I understand that most related packages/apps are installed via helper scripts like Kiauh or an OS like RatOS, and in general, they do seem to match the
key
with the fullrepo_name
so this could be considered a config issue rather than a bug.
Ok, this cleared things now, and yes, you are correct! We should use repo_name
there, as you are doing in your PR.
Awesome! :tada:
Apologies about not including an actual config. For reference, here's the one I thought I included:
[update_manager led-effect]
type: git_repo
path: ~/led-effect
origin: https://github.com/julianschill/klipper-led_effect.git
is_system_service: False
My local version is on commit https://github.com/julianschill/klipper-led_effect/commit/28a3c25220deba27b35b15e96d4dae3b761cdec1, 1 commit behind master @ https://github.com/julianschill/klipper-led_effect/commit/03a46eab5670c2934b38093993834f822a56c0fe
Fluidd Version
all
Browser
Chrome, Firefox, Safari, Edge
Device
Desktop PC, Laptop, Mobile device (Phone, Tablet or similar)
Operating System
Windows, macOS, Linux, Android, iOS
What happened
In the
Software Updates
section of theSettings
UI, When the user has opened the Commit History modal for a versioned package type (git_repo
,zip
,web
), The URL for both the author's name, and the commit hash are not based on the repo's URL.Using the config below, the URLs produced are
//github.com/owner/package-key[/commit/$sha]
What did you expect to happen
The URL(s) should have been
//github.com/owner/klipper-plugin_name[/commit/$sha]
How to reproduce
git_repo
type[update_manager pkg]
section to your Moonraker configCheck for Updates
in theSoftware Updates
section of theSettings
UICommit History
modalAdditional information
I understand that most related packages/apps are installed via helper scripts like Kiauh or an OS like RatOS, and in general, they do seem to match the
key
with the fullrepo_name
so this could be considered a config issue rather than a bug.With that said though, Moonraker's API does return the
repo_name
along with theowner
which is enough rebuild (all?) web UIs for git repos.One side note too: The link to the right of the package name links directly to the
remote_url
which is fine for GitHub HTTPS links but this could also be changed to theowner/repo_name
structure.This is an example of the Moonraker API response for
moonraker:7125/machine/update/status
including therepo_name
key.