fluidd-core / fluidd

Fluidd, the klipper UI.
https://docs.fluidd.xyz
GNU General Public License v3.0
1.42k stars 434 forks source link

Floating camera view does not follow rotation setting #1504

Closed gyscos closed 1 month ago

gyscos commented 1 month ago

Fluidd Version

1.30.4

Browser

Firefox

Device

Desktop PC

Operating System

Linux

What happened

I have a camera configured (using crowsnest). In the fluidd config for that camera, I rotate the image by 180 degrees. This works when the view is embedded in the "home" page, but when I click on the "floating" button to have the camera stream as a kind of floating popup, the view reverts back to being non-rotated.

If I press the fullscreen button instead, the view is properly rotated.

What did you expect to happen

The floating view would be rotated just like the fullscreen and embedded views are.

How to reproduce

Add a camera with 180 degrees rotation. Observe proper rotation in the Home page. Click on the popup/floating button for that camera. Observe a lack of rotation applied.

Additional information

Using webrtc for the stream.

Screenshot of the properly rotated view while embedded: Screenshot From 2024-10-09 10-22-18

Screenshot of non-rotated view while floating: Screenshot From 2024-10-09 10-22-26

EDIT: actually it doesn't even look rotated, but vertically flipped... weird.

pedrolamas commented 1 month ago

Hi @gyscos , thank you for opening this issue.

This is however expected as the Fluidd settings only apply to the embedded Fluidd player and nothing else.

You need to rotate/flip the source stream on crownest settings: https://crowsnest.mainsail.xyz/configuration/cam-section#custom_flags or https://crowsnest.mainsail.xyz/configuration/cam-section#v4l2ctl depending on the streamer you choose.

gyscos commented 1 month ago

Unfortunately it doesn't seem my usb camera has any rotation control, and crowsnest doesn't handle rotation itself either.

I didn't realize the floating popup was a "picture in picture" feature of firefox and not something fluidd is implementing itself - sorry for the noise!

pedrolamas commented 1 month ago

I would expect that crownest would allow such a feature but nevertheless it's not something we can do anything here I'm afraid...